Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link not working #28

Open
EstebanRezz opened this issue Dec 28, 2022 · 23 comments
Open

Link not working #28

EstebanRezz opened this issue Dec 28, 2022 · 23 comments
Labels
bug Something isn't working

Comments

@EstebanRezz
Copy link

Hi, I'm trying to put a link to a file in the welcome file:

**Bienvenido **
Por favor revisar debajo las Preguntas Frecuentes para mas Informacion.

But it doesnt work. Whn I click on it nothing happens

Thanks in advance
@julien-nc
Copy link
Member

julien-nc commented Dec 28, 2022 •
edited
Loading

Hi,

Could you provide an example markdown file you're using? Or you can just post the same content as in your first message but in a code block.

It's working fine one my side with this kind of markdown content:

here is an [absolute](https://yep.net/plop) link
here is a [relative](/lala) one

In the widget, could you right-click on a link, select "inspect" and copy the <a... tag?

@julien-nc
Copy link
Member

Btw, assuming the markdown you mentioned in your post is:

**Bienvenido **
Por favor revisar debajo las [Preguntas Frecuentes](/Faq.md) para mas Informacion.

This is working fine on my side.

@EstebanRezz
Copy link
Author

EstebanRezz commented Dec 29, 2022 via email

@julien-nc
Copy link
Member

A video won't help much IMO 😁.

  • I need an example markdown file.
  • You could inspect (right click -> inspect) the link displayed in the welcome widget and show me the value of its href attribute.
  • You could try with a fresh browser profile to check if your extensions are blocking the link.

@EstebanRezz
Copy link
Author

EstebanRezz commented Dec 30, 2022 via email

@EstebanRezz
Copy link
Author

EstebanRezz commented Jan 4, 2023 via email

@Philglo
Copy link

Philglo commented Aug 22, 2023

I,
I made a a .md file in Nextcloud, when I "link to file or folder" inside my nextcloud, the adress go to the root. of my site and no in my nextcloud. Could you hel me. Regards

@kyteinsky
Copy link
Contributor

Hello,
Linking to local files isn't a feature per se but you can use this method to get it working. Say you want to link a file "Inversores/Faq.md".
Find out the file id of this file from either the address bar of the browser after opening/viewing the file -or- by getting a local share link from the right side sharing panel.
Now you need to place a link in the markdown file as follows:

[link to the doc](/f/150)

where 150 should be replaced with the file id of the desired file.

If this isn't suited to you, consider using public share links.
I hope that solves your issue.

@kyteinsky kyteinsky mentioned this issue Sep 6, 2023
Closed
@Sandro1955
Copy link

Sandro1955 commented Mar 10, 2024 •
edited
Loading

Salve, ho lo stesso problema. Il link funziona perfettamente dal file .md, purtroppo cliccando sul link della scheda di benvenuto del cruscotto il sistema restituisce l'errore "La pagina non è stata trovata sul server o forse non ti è permesso vederla". Grazie a chi potrà aiutarmi.

@kyteinsky
Copy link
Contributor

Hello @Sandro1955, please use English language so people don't need to copy paste this into a translation service.

A sample .md file would be helpful to get to know your issue better.

@Sandro1955
Copy link

I inserted a welcome page that calls up a .md file that contains a link to a local folder. Unfortunately the link doesn't work and always returns the error "the page was not found on the server or maybe you don't have permission to see it". Thanks.
welcome.md

@kyteinsky
Copy link
Contributor

kyteinsky commented Mar 12, 2024 •
edited
Loading

Hi, assuming you generate the link from the text app, yes this is a bug from welcome app's perspective. I will open a bug report in the text app's repo to get them to generate an absolute URL since modifying the relative URL afterwards in the welcome app would feel hacky and might lead to more bugs. Thanks for reporting this!

On second thought, let me discuss the solution other engineers.

@kyteinsky kyteinsky added the bug Something isn't working label Mar 12, 2024
@EstebanRezz
Copy link
Author

EstebanRezz commented Mar 12, 2024 via email

@kyteinsky
Copy link
Contributor

@EstebanRezz This issue was created by you so you're subscribed to it. You may click on the unsubscribe link in the email or do the same after logging into to your github account. I cannot do this for you.

@Sandro1955
Copy link

Thanks for the help. I await communication when the problem will be resolved. Greetings

@Sandro1955
Copy link

There are news ?

@kyteinsky
Copy link
Contributor

Hi sorry for the late reply. I talked to Max, there are benefits of having relative links like having the same link open in files and collectives. So, the welcome app should do the post-processing to convert them into absolute links. I'll do it most probably this week.

@Sandro1955
Copy link

still no news?

@kyteinsky
Copy link
Contributor

hey, I got help from Julien and Text app's expert.

The link in the file that you attached has a path /Foto/. The file/folder paths are not supported since when some other user looks at the same link, the shared path may be different. File ID is the way to link files/folders. The Text app now does absolute links instead of relative links as per the latest release and it is the preferred way to generate the markdown files instead of composing the file in a different editor. See if the updated app solves your issue.

An example of a link to a folder: https://stable29.local/index.php/f/583

Unrelated, but for images, they should be added from the text app only and not just linked with text since the former adds the images to a .attachments.fileId directory eliminating the file ownership hassle and is good for security. We only show previews for these images. I'll update the readme with this information.

@Sandro1955
Copy link

Thanks for the help. However, I can't figure out how to detect the file/folder.

@kyteinsky
Copy link
Contributor

How do you mean? Looking at the url only you cannot tell if it points to a file/folder but when you add it, you know what it was. And the Text app shows a small popup which shows if it is a file/folder. We don't have that in the dashboard widget.
The text for the link should do the job of explaining its contents.

@Sandro1955
Copy link

hey, I got help from Julien and Text app's expert.

The link in the file that you attached has a path /Foto/. The file/folder paths are not supported since when some other user looks at the same link, the shared path may be different. File ID is the way to link files/folders. The Text app now does absolute links instead of relative links as per the latest release and it is the preferred way to generate the markdown files instead of composing the file in a different editor. See if the updated app solves your issue.

An example of a link to a folder: https://stable29.local/index.php/f/583

Unrelated, but for images, they should be added from the text app only and not just linked with text since the former adds the images to a .attachments.fileId directory eliminating the file ownership hassle and is good for security. We only show previews for these images. I'll update the readme with this information.

in the example you indicate the id number 583, where I find this id number in my database ?

@kyteinsky
Copy link
Contributor

It will be automatically populated with a nice UI if you use this Text app to add the files/folders in your markdown file. It is the recommended and easier way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@julien-nc @kyteinsky @Philglo @Sandro1955 @EstebanRezz