-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback command for micromamba #4302
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Note that this PR only addresses the Another change would required to address point 1, the (I'm neutral on how y'all handle this, just want to make sure its clear). |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
We are going to deprecate the support for Micromamba #4464. Therefore closing w/o merging |
Reopening, as not sure we should remove Mamba just yet, at least until conda/conda#13037 is solved. |
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
@jorgee avoid the fallback approach can be a mess to debug, there should be a separate command when the micromamba flag is set |
…pecified Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
I have pushed new changes with this modification. I think it is ready |
modules/nextflow/src/test/groovy/nextflow/executor/BashWrapperBuilderTest.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
…/nextflow into 4161-micromamba-info-command
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: jorgee <jorge.ejarque@seqera.io> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Jorge Ejarque <jorgee@users.noreply.github.com> Co-authored-by: jorgee <jorge.ejarque@seqera.io> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Close #4161
Tested with micromamba image: