Fix closure rendering in yaml and json config #5408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
reviewed
Oct 17, 2024
Comment on lines
+365
to
+372
| if( value instanceof Map ) { | ||
| final map = value as Map | ||
| final ret = new LinkedHashMap(map.size()) | ||
| for( Map.Entry entry : map.entrySet() ) { | ||
| ret.put(entry.key, normaliseObject0(entry.value)) | ||
| } | ||
| return ret | ||
| } |
There was a problem hiding this comment.
is there a case where you would have a closure in a list? I can't think of any
There was a problem hiding this comment.
Likely we don't any in the config, but as general solution makes sense to have it
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
alberto-miranda
pushed a commit
to alberto-miranda/nextflow
that referenced
this pull request
Nov 19, 2024
…fast] Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Ben Sherman <bentshermann@gmail.com> Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the rendering of closures in config file reporting as strings.
For example
or