Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax docs #5542

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Update syntax docs #5542

merged 2 commits into from
Nov 26, 2024

Conversation

bentsherman
Copy link
Member

Minor corrections to syntax rules for strings and the workaround for dynamic config includes.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from ewels November 26, 2024 14:28
@bentsherman bentsherman requested a review from a team as a code owner November 26, 2024 14:28
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 3e57f37
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67463c2ea166170008003f7d
😎 Deploy Preview https://deploy-preview-5542--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


```nextflow
def id = 'SRA001'
assert 'SRA001.fastq' ~= /${id}\.f(?:ast)?q/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't said to keep slashy string (with interpolation) and deprecate dollar slash strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neither are supported. I am looking into slashy strings here but until I can get it to work, they are effectively not supported

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we should consider a lack in the lang server, but i'd keep in the lang reference

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dynamic slashy strings are not mentioned in the language reference. The effort to support them (nextflow-io/language-server#51) is purely exploratory. There is no guarantee that we can support it or that it would be wise to do so. Meanwhile, a regular dynamic string can be used by simply replacing \ with \\.

I will add it in the future if I feel confident that we can support it.

@bentsherman bentsherman merged commit 308d5a5 into master Nov 26, 2024
11 checks passed
@bentsherman bentsherman deleted the docs-syntax-guide branch November 26, 2024 21:25
@bentsherman bentsherman removed the request for review from ewels November 26, 2024 21:25
christopher-hakkaart pushed a commit to christopher-hakkaart/nextflow that referenced this pull request Dec 3, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Christopher Hakkaart <chris.hakkaart@seqera.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants