Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the run if publish thread pool times out #5578

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bentsherman
Copy link
Member

Close #5577

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit b4aa73d
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/675c5feb7f12fa000845190a

@bentsherman bentsherman marked this pull request as ready for review December 9, 2024 15:10
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Copy link
Member Author

@pditommaso ready for review. It will fail the run if workflow.output.ignoreErrors is false and the finalizer or publish pool times out

@pditommaso
Copy link
Member

Would have not been simpler to throw an exception here and rely on the abort mechanism?

@bentsherman
Copy link
Member Author

Probably would be simpler. In that case the abort() would be called in the middle of destroy(), is that expected to work?

@pditommaso
Copy link
Member

I think the abort will be called implicitly by throwing an exception. see here

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Copy link
Member Author

Right, just wondering if abort() has some implicit assumption that destroy() has not been called yet. But from the code it looks safe. Simplified things a bit

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail the run if the publish thread pool times out
2 participants