Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at fixing the publish path issue. #5599

Closed
wants to merge 1 commit into from
Closed

Conversation

robsyme
Copy link
Collaborator

@robsyme robsyme commented Dec 11, 2024

Still a draft, not to be merged.

This is very minimal fix for #5476. With this patch, I've noticed the inclusion of a "/./" in the prefix when publishing to blob storage, which will have to be fixed.

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 8e87621
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/675a0ec76566850008951d1d

This is quick and dirty, and I've noticed the inclusion of a "/./" in the prefix when publishing to blob storage, which will have to be fixed.

Signed-off-by: Rob Syme <rob.syme@gmail.com>
@bentsherman
Copy link
Member

it's a bit more complicated... I think I have a solution already in #5502

feel free to battle test it, I think it should work

@bentsherman
Copy link
Member

there were a lot of bugs 😅

@robsyme
Copy link
Collaborator Author

robsyme commented Dec 11, 2024

Lol. It did seem a little too easy 😆

Testing your branch now, I'll close this one out.

@robsyme robsyme closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants