Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax docs #5615

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Update syntax docs #5615

merged 5 commits into from
Dec 18, 2024

Conversation

bentsherman
Copy link
Member

Add some notes to the syntax migration guide, as well as some updates for v1.0.3 of the language server.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from a team as a code owner December 16, 2024 18:23
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for nextflow-docs-staging failed. Why did it fail? →

Name Link
🔨 Latest commit ddf5cbf
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67627e6a8c4aca00089322d5

@bentsherman
Copy link
Member Author

Not sure why the netlify build is failing. But would be good to merge these changes this week to go along with the vscode extension released today.

Copy link
Contributor

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and suggestions.

docs/vscode.md Outdated Show resolved Hide resolved
docs/vscode.md Outdated Show resolved Hide resolved
docs/vscode.md Outdated Show resolved Hide resolved
docs/vscode.md Outdated Show resolved Hide resolved
docs/vscode.md Outdated Show resolved Hide resolved
bentsherman and others added 2 commits December 17, 2024 09:44
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Copy link
Contributor

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing and I can't see any reason why. The text itself is good to go. I don't have access to the netlify logs to view what's going wrong.

@bentsherman
Copy link
Member Author

Not sure why netlify isn't working, but it is not required. If you can just approve then I can merge

@bentsherman bentsherman merged commit a860a3d into master Dec 18, 2024
7 of 11 checks passed
@bentsherman bentsherman deleted the update-syntax-docs branch December 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants