Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmc/2047 Fab theming #86

Closed
wants to merge 1 commit into from
Closed

Nmc/2047 Fab theming #86

wants to merge 1 commit into from

Conversation

surinder-tsys
Copy link

Customized floating action button.

  • Tests written, or not not needed

@surinder-tsys surinder-tsys added the custom MagentaCLOUD customisation label May 14, 2023
@surinder-tsys surinder-tsys force-pushed the nmc/2047-fab_theming branch 2 times, most recently from 7130c48 to 9b86617 Compare May 18, 2023 18:16
@tobiasKaminsky
Copy link

Hm. This approach works, but is error prone for future.
E.g. you already now overlooked DocumentScanActivity:94, where it is also being called.

I tried to overload the function, but did not succeed.

@surinder-tsys
Copy link
Author

Hm. This approach works, but is error prone for future. E.g. you already now overlooked DocumentScanActivity:94, where it is also being called.

I tried to overload the function, but did not succeed.

We won't be using NC scan functionality in our app as we have our own. That's why I didn't made any changes in that file.

@surinder-tsys surinder-tsys added the build-ready Customization to include into build label Jul 13, 2023
@surinder-tsys surinder-tsys changed the title Nmc/2047 fab theming Nmc/2047 Fab theming Feb 8, 2024
@surinder-tsys
Copy link
Author

This PR code has been moved to #106 to optimize PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved build-ready Customization to include into build custom MagentaCLOUD customisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants