-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs-ci: make linkcheck
prone to transient network failures
#106
Comments
FWIW, I did see these types of errors occasionally (locally) while I was working on correcting links across the various repos. Thanks for creating the issue; if this happens frequently, I'll handle the split/continue-on-error changes. |
Documenting another occurrence:
|
And another, twice in a row. |
BOOOOOO. I will pick this up and make it |
Also add `continue-on-error-comment` step, so that if linkcheck fails, a comment will be added to the PR, instead of a silent failure with a green check.
Also add `continue-on-error-comment` step, so that if linkcheck fails, a comment will be added to the PR, instead of a silent failure with a green check.
I'm wondering if On the other hand, with something like the CI failures we have currently or mainmatter/continue-on-error-comment, I'm worried that it could be unnecessarily noisy given the high rate of these failures as of lately (I've seen many in Augur, but no longer linking them back to here). Some alternatives:
I realize this comment is coming a bit late but it's longer-term thinking. |
I generally agree with @victorlin here. |
I've just run into this error on an Augur PR which did not change any docs links:
This seems like a transient network error which shows up as a failing check ❌ on the PR which confused me at first.
make linkcheck
is a recent addition (#104), so it's hard to tell how often we will run into this. If it happens often, it might be worth splittinglinkcheck
into a separate job on docs-ci and usingcontinue-on-error: true
.The text was updated successfully, but these errors were encountered: