actions/setup-debugger: Pause for 1 second after interrupting an exec... #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This binary may be present during local development and testing, so stop it from cluttering `git status` or accidentally getting committed.
…to allow /proc/$pid/cmdline to have contents. It consistently seemed to be empty (?) on GitHub Actions runners without this brief sleep. This hacky solution worked in the moment, and so it's what I'm committing since its tested. There are likely better solutions that don't rely on sleeping, like checking for the property we care about (e.g. does /proc/$pid/cmdline have contents?), but I didn't try those and so don't want to commit something that doesn't work. Log the full argv for an easier time debugging the debugger next go around.
tsibley
force-pushed
the
trs/actions/setup-debugger/fix-empty-cmdline-race
branch
from
1c15abc
to
ffe4299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to allow /proc/$pid/cmdline to have contents. It consistently seemed to be empty (?) on GitHub Actions runners without this brief sleep. This hacky solution worked in the moment, and so it's what I'm committing since its tested. There are likely better solutions that don't rely on sleeping, like checking for the property we care about (e.g. does /proc/$pid/cmdline have contents?), but I didn't try those and so don't want to commit something that doesn't work.
Log the full argv for an easier time debugging the debugger next go around.
Checklist