Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mid-point rooting to refine #1257

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

rneher
Copy link
Member

@rneher rneher commented Jul 22, 2023

Description of proposed changes

Add option to mid-point root to refine, both with and without timetree.

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.

@rneher rneher requested a review from huddlej July 22, 2023 09:24
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: -0.05% ⚠️

Comparison is base (8bc8b0d) 69.85% compared to head (d963542) 69.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   69.85%   69.80%   -0.05%     
==========================================
  Files          67       67              
  Lines        7155     7160       +5     
  Branches     1740     1742       +2     
==========================================
  Hits         4998     4998              
- Misses       1851     1855       +4     
- Partials      306      307       +1     
Files Changed Coverage Δ
augur/refine.py 64.28% <14.28%> (-1.57%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me! I included an example below based on the Zika tutorial.

Root on midpoint:
image

Root on best:
image

@huddlej huddlej force-pushed the feat/allow-mid-point-rooting branch from f585051 to d963542 Compare August 11, 2023 18:52
@rneher rneher merged commit 1d92f6d into master Aug 11, 2023
26 checks passed
@rneher rneher deleted the feat/allow-mid-point-rooting branch August 11, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants