Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export clock rate covariance matrix and std dev #1284

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Aug 16, 2023

Description of proposed changes

Exports the clock rate covariance matrix and std dev from the phylogenetic regression performed by TreeTime in augur refine. This information was already available in a TreeTime data structure and it is useful to users who do not know the std dev of their pathogen's clock rate already.

Testing

  • Adds functional tests for behavior when no clock rate is provided by the user and when one is. In the latter case, we shouldn't have a covariance matrix.
  • Checks pass

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.

@huddlej huddlej requested a review from rneher August 16, 2023 23:25
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (5b9ab8d) 69.87% compared to head (c28535b) 69.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   69.87%   69.92%   +0.04%     
==========================================
  Files          67       67              
  Lines        7158     7161       +3     
  Branches     1744     1745       +1     
==========================================
+ Hits         5002     5007       +5     
+ Misses       1849     1848       -1     
+ Partials      307      306       -1     
Files Changed Coverage Δ
augur/refine.py 65.72% <100.00%> (+1.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Exports the clock rate covariance matrix and std dev from the
phylogenetic regression performed by TreeTime in augur refine. This
information was already available in a TreeTime data structure and it is
useful to users who do not know the std dev of their pathogen's clock
rate already.

Adds functional tests for behavior when no clock rate is provided by the
user and when one is. In the latter case, we shouldn't have a covariance
matrix.
@huddlej huddlej force-pushed the export-clock-cov-and-std-dev branch from b6ebe95 to c28535b Compare August 24, 2023 20:38
@huddlej huddlej merged commit 435bd29 into master Aug 24, 2023
27 checks passed
@huddlej huddlej deleted the export-clock-cov-and-std-dev branch August 24, 2023 21:00
@huddlej
Copy link
Contributor Author

huddlej commented Aug 24, 2023

Merged after 👍🏻 from Richard on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant