-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move filtering/subsampling docs into a separate file #1431
Conversation
This makes it possible to use in the Nextstrain docs project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I forgot about the include
directive!
Not asking for a change, but just curious, what prompted you to make this a separate page that can be included in the Nextstrain docs project rather than just a direct link to the Augur project?
(I might have answered my own question, this is a nice flow in the Nextstrain docs project)
Yes, I thought this guide should be shown in a context above Augur docs, where one can see other higher-level guides in the same sidebar. The docs fetching is meant to be a temporary solution but it seems to be working well. |
😬 It's full of pitfalls (both technical and human), and I'd prefer to continue to excise it rather than expand it. |
The goal here was to show the subsampling guide contents both on the main docs project (because it's a commonly ask) and also directly on the Store |
Nod. I like the idea of keeping the |
Description of proposed changes
This makes it possible to use in the Nextstrain docs project.
Related issue(s)
Checklist
If making user-facing changes, add a message in CHANGES.md summarizing the changes in this PRno user-facing changes