augur curate format-dates: accept masked dates #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1501 +/- ##
=======================================
Coverage 69.53% 69.53%
=======================================
Files 73 73
Lines 7788 7789 +1
Branches 1905 1905
=======================================
+ Hits 5415 5416 +1
Misses 2087 2087
Partials 286 286 ☔ View full report in Codecov by Sentry. |
joverlee521
force-pushed
the
format-dates-accept-mask
branch
2 times, most recently
from
95df70f
to
2cd7111
Compare
genehack
approved these changes
Jul 1, 2024
Moving to a subdirectory with the intent of separating the tests into more modular tests and adding new tests.
Shows the current behavior of how augur curate format-dates can handle already masked dates.
These are default date formats that the command should parse without additional input from the user, which includes the ISO 8601 date format and it's various masked forms. Resolves #1496
joverlee521
force-pushed
the
format-dates-accept-mask
branch
from
2cd7111
to
25f4993
Compare
|
Rebased on to master to resolve merge conflicts in the changelog. |
victorlin
approved these changes
Jul 2, 2024
joverlee521
added a commit
that referenced
this pull request
Oct 17, 2024
Because of the added default values in <#1501>, this is no longer a required argument. The alternative is to explicitly mark this option as `required=True`, but that's a breaking change that can be considered later. Currently, if `--expected-date-formats` is not provided and dates match the defaults, then it's a no-op. If dates do not match the default formats, it will raise a loud error so the user can add the custom formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add
DEFAULT_EXPECTED_DATE_FORMATStoaugur curate format-dates. These are default date formats that the command should parse without additional input from the user, which includes the ISO 8601 date format and it's various masked forms.Also includes some minor restructuring of tests for
format-datesto be more modular cram tests.Related issue(s)
Resolves #1496
Checklist