-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the subcmd name in the validate_output error message [#1539] #1540
Conversation
45948f2
to
d11b123
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
==========================================
- Coverage 69.90% 69.90% -0.01%
==========================================
Files 75 75
Lines 7882 7888 +6
Branches 1933 1933
==========================================
+ Hits 5510 5514 +4
- Misses 2086 2088 +2
Partials 286 286 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment in #1518 came back to bite real quick 😅
there's no good way to check for the output error. Hopefully we just never see it!
I spent like, 30 seconds thinking about mocking something up to cause the error so I could write a test, then settled for manually validating it on the broken version of |
d11b123
to
790dcdc
Compare
Once this is merged, I think good to release along with #1531 as Augur 25.1.1 (Probably wait till Monday so we don't do a Friday release 🙈) |
In the harsh light of morning, I realized, while functional tests would be a PITA, I could totally trivially unit test the |
0c03780
to
e535507
Compare
e535507
to
58db430
Compare
Description of proposed changes
This puts the full sub-command name into the error message shown when the output records have inconsistent field names.
Related issue(s)
#1539
Checklist