-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links [#1569] #1570
Fix broken links [#1569] #1570
Conversation
3099035
to
100caba
Compare
@victorlin thanks for the detailed review. I've fixed everything you noted, and done a further side-by-side comparison of both the v5->v6 and the v6 docs — I think these are now as close as possible to the originals, and generally better in a couple respects (e.g., the side by side config in the new version is IMO much nicer). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
+ Coverage 70.23% 70.51% +0.28%
==========================================
Files 76 78 +2
Lines 7990 8107 +117
Branches 1946 1966 +20
==========================================
+ Hits 5612 5717 +105
- Misses 2092 2100 +8
- Partials 286 290 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all the changes this time so these should be the final tweaks to be made.
100caba
to
3e4a5a9
Compare
All addressed; ready for final check. |
Description of proposed changes
augur
Related issue(s)
Closes #1569
Checklist