Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyright: Use basic ruleset explicitly #1659

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Nov 1, 2024

Description of proposed changes

This is the default for pyright but not basedpyright, a fork of Pyright that I am using. Setting explicitly also provides more context for the following rule exceptions.

Related issue(s)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

This is the default for pyright but not basedpyright¹, a fork of Pyright
that I am using. Setting explicitly also provides more context for the
following rule exceptions.

¹ https://docs.basedpyright.com/latest/benefits-over-pyright/better-defaults/#typecheckingmode
@victorlin victorlin self-assigned this Nov 1, 2024
@victorlin victorlin merged commit efabf11 into master Nov 1, 2024
28 of 29 checks passed
@victorlin victorlin deleted the victorlin/pyrightconfig branch November 1, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants