-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically add tip labels #237
Comments
Somewhat temporarily fixed in c347f58 where I draw tip labels iff < 50 tips inView, and they appear after the branches/tips have transitioned |
|
@jameshadfield should tip labels be re-calculated each time Or rather, every time |
I believe commit 579c524 addresses the final bullet point. |
#728 addresses the parts of this issue where tip label visibility would not update after Date Range change, and where tip labels would not re-appear after layout change. |
For SVG performance (especially when transitioning), we need to dynamically add and remove branchLabels and tipLabels from the DOM. With a zoomed tree with labels showing, I bet it's going to be safe to transition the ones that are visible.
The text was updated successfully, but these errors were encountered: