fix #915: correctly determine tip counts based on visibility #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count of fully visible nodes, not all in-view nodes
frogsquire
changed the title
|
Thanks Maxwell -- this is great :) Merged into master with an additional commit to improve the font sizes (but plenty more work to be done re: picking font sizes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correctly determines whether to show tips based on the number of in-view, fully visible nodes (as opposed to partially visible, unselected nodes), not based on the number of in-view nodes in total.
Related issue(s)
Fixes #915
Related to #237
Testing
What steps should be taken to test the changes you've proposed?