collapsible filter lists in footer #1414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes lists of filter options in the footer collapsible (or rather expandable since they are collapsed by default); see nextstrain/ncov#738 (comment) for motivation for doing this.
Uses https://www.npmjs.com/package/react-collapsible similar to the situation report listings on https://nextstrain.org/sars-cov-2.
Maybe it would be better to just use a traditional dropdown (as the color by does in the sidebar) rather than this special collapsible component - when interacting with it, I'm not sure what it gives us in terms of a good user experience that a regular dropdown menu does not. Maybe being able to see all options at once listed next to one another? Or being able to see which ones are selected while you are looking through options? Interested in feedback on this!