Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download empty tree #1591

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Fix download empty tree #1591

merged 3 commits into from
Nov 6, 2022

Commits on Nov 2, 2022

  1. helperFunctions/treeToNewick: use idxOfFilteredRoot

    In cases where the user has filtered the tree, the `idxOfFilteredRoot`
    is the root of the selected tips instead of `idxOfInViewRootNode`.
    By using `idxOfFilteredRoot` as the root of the tree, this now acts the
    same way as the manual work-around of clicking "Zoom to selected" then
    downloading the tree.
    
    However, this does _not_ fix the case where the filter may have created
    multiple subtrees. If there are multiple subtrees without a most recent
    common ancestor, this function will still produce an empty Newick tree.
    joverlee521 committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    613b9a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Configuration menu
    Copy the full SHA
    79d3bb9 View commit details
    Browse the repository at this point in the history
  2. Raise an error when an empty tree is created

    Raise an error when `treeToNewick` creates an empty tree is created
    because this is undesired behavior. Created a custom error class for
    this so that we could include details in the warning notification for
    the user.
    joverlee521 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4ff518c View commit details
    Browse the repository at this point in the history