Show github links as dataset (in sidebar) for community URLs #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move from text "Data sourced from" text to an icon. I think this conveys the same information while looking cleaner.
|
I think this is really great @jameshadfield. I made some small styling adjustments. If you find a better icon in Font Awesome (https://fontawesome.com/v4.7.0/icons/) feel free to adjust. I don't think I'd add anything else to the sidebar. We may consider a "Community Build" badge in the top right of main section (to the right of title) or something like this. Or may consider revising title block to include author information, but this is a larger UX decision. If you're happy, please merge. |
trvrb
approved these changes
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For community URLs, this would change the dataset text in the sidebar to: