transform-field-names: Skip field if old_field_name == new_field_name
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
j23414
reviewed
May 28, 2024
| WARNING: skipping rename of isolate because record already has a field named strain. | ||
| {"strain":"A","isolate":"B"} | ||
|
|
||
| If the `--field-map` overwrites an existing field if using `--force` flag. |
There was a problem hiding this comment.
minor non-blocking nit-pick: "The --field-map may overwrite an existing field ..."
There was a problem hiding this comment.
Updated in force-push
j23414
approved these changes
May 28, 2024
| @@ -27,6 +28,10 @@ if __name__ == '__main__': | |||
| field_map = {} | |||
| for field in args.field_map: | |||
| old_name, new_name = field.split('=') | |||
|
|
|||
| if old_name == new_name: | |||
| continue | |||
genehack
approved these changes
May 28, 2024
Show the current behavior of `transform-field-names` in preparation for updating the behavior in following commit.
joverlee521
force-pushed
the
update-transform-field-names
branch
from
0f00c52
to
1f9a382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
If the old field name is the same as the new field name (case sensitive), then skip renaming.
Resolves #37
Checklist
If adding a script, add an entry for it in the README.