Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Nextclade v3 #281
Migrate to Nextclade v3 #281
Changes from all commits
3850af5
cbcc7d4
1234479
54ca356
475b64f
6b5153c
42c1040
dab86ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shaved off 8 mins for the Nextclade job, but only 3 mins off the total workflow.
Using all of the cores prevents Snakemake from scheduling other concurrent jobs such as
upload_to_s3
jobs. The upload jobs can be slow as well, so we could adjust the threads to something likeworkflow.cores * 0.75
.It's only a couple minute difference so I'm not going to worry about it for now.