ingest: Add tests #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joverlee521
reviewed
Jun 15, 2022
Comment on lines
+127
to
+144
| def test_wildcards_work_if_partial_match_exists(self, tmpdir): | ||
| """Test wildcards still work even when partial matches exist.""" | ||
| lines = ( | ||
| "a/b/c/d\t1/2/3/4", | ||
| "a/*/*/z\t1/*/*/26", | ||
| ) | ||
| geolocation_rules = get_geolocation_rules(tmpdir, lines) | ||
| assert get_annotated_geolocation(geolocation_rules, ("a", "b", "c", "z")) == ("1", "*", "*", "26") |
There was a problem hiding this comment.
This test fails on master, but passes if rebased onto #55
victorlin
force-pushed
the
victorlin/add-transform-tests
branch
from
ee0d29f
to
bf1ad54
Compare
- Add bin/__init__.py so files in bin/ can be imported in a Python script. - Rename apply-geolocation-rules to apply_geolocation_rules.py since filenames with dashes or lack of .py extension can't be imported without messing with importlib. - TODO: Rename other scripts
Reword a test name and docstring.
victorlin
force-pushed
the
victorlin/add-transform-tests
branch
from
bf1ad54
to
8dac880
Compare
|
This only adds tests for |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
I wrote these tests so I can understand how things work, but they also might be good to have in the repo. Filenames and tests location up for debate.
If this is desired, we don't have to add tests for all Python scripts in this PR, but it would be good to rename the scripts with underscores and
.pyextension here.Related issue(s)
N/A
Testing
See CI.