Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest/apply-geolocation-rules: update general rules logic #55

Merged
merged 3 commits into from
Jun 20, 2022

Commits on Jun 15, 2022

  1. ingest/apply-geolocation-rules: update general rules logic

    Previously, we would backfill `rule_traversal` with wildcards ("*")
    if we could not find a matching rule for a particular `raw_geolocation`.
    This would NOT work for cases where there are partial rule matches AND
    wildcard rules that match. I realized the flaw in this logic
    while responding to @victorlin's post-merge review:
    #41 (comment)
    
    This commit updates the logic for when there are no matching rules. The
    `rule_traversal` is reset to the last index that is currently not a
    wildcard rule, and then change this value to a wildcard. This allows the
    recursive function to try different iterations of `rule_traversal` with
    different combinations of raw values and wildcards.
    joverlee521 committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0f6e1c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. chore: Formatting, Update ingest/bin/apply-geolocation-rules

    Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com>
    corneliusroemer and victorlin authored Jun 20, 2022
    Configuration menu
    Copy the full SHA
    e3a87f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b381af4 View commit details
    Browse the repository at this point in the history