fix: prevent run-away bandwith #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ivan-aksamentov
force-pushed
the
master
branch
2 times, most recently
from
93f31a9 to
edefa32
Compare
corneliusroemer
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
This significantly improves runaway bandwidth
Bandwidth can still get large when --excess-bandwidth is on the order of ~200 or larger.
However, I'm not aware of datasets where we would need such large bandwidth.
This is in any case an improvement.
See https://neherlab.slack.com/archives/C015PFP5V44/p1693397022589159 for detailed investigation/testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.