fix: zero length branches can still have aa mutations even without nu… #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
regarding your concern on the order of union and difference. I don't think this is an issue because in |
by checking first whether the candidate_node equals the current best node, the set of conditionals gets simplified and multiple previous conditions are combined into one. There are now three possible results: - move to the parent node. Happens whenever best_node==candidate_node and all mutations that lead to the candidate_node are also found in the private mutations of best_node - move to a child (candidate_node!=best_node). This only happens when there is at least one mutation shared. - stay: in this case, the final placing is either a direct child of candidate_node, or splits the branch leading to it.
- replace `.left.nuc_muts.is_empty()` with a check for `n_left_muts==0` which is calculated using the same function as `n_shared_muts`. - fix left/right error is split result when attaching to the root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…c muts
This problem arose when we are moving the attachment point across a branch of a node that had aa mutations that didn't correspond to any nucleotide mutations. The problem arose only in the specific case when the branch length of a terminal node is zero.