Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include workflow runs on default branch #9

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Apr 11, 2024

Description of proposed changes

This is my work-around to resolve #8 since I don't understand what's going on under the hood in steampipe and why the subquery filter is not executed.

Checklist

  • Checks pass

This is my work-around to resolve #8
since I don't understand what's going on under the hood in steampipe
and why the subquery filter is not executed.
@joverlee521
Copy link
Contributor Author

The CI artifact from yesterday's run isn't showing up (we probably hit a limit for artifacts with a run every 5 minutes), so I retriggered the CI workflow.

@joverlee521
Copy link
Contributor Author

Leaving the CI artifact's pathogen-workflows.json here for any future inspection.

Download and locally generate the status page within the repo directory with:

mv ~/Downloads/pathogen-workflows.json build/
make

Comparing the dengue workflow runs on the status page

From this PR, it only includes the two runs since the PR for the dengue workflow was merged:

Screenshot 2024-04-11 at 3 08 01 PM

Current status page includes all previous testing runs of the workflow:

Screenshot 2024-04-11 at 3 08 34 PM

@joverlee521 joverlee521 marked this pull request as ready for review April 11, 2024 22:11
@joverlee521 joverlee521 requested a review from a team April 11, 2024 22:21
@joverlee521
Copy link
Contributor Author

I think reasonable for the status page to only show the default branch runs and I think this was always the intention?
Maybe future work can create a separate page or filter for non-default branch runs.

Merging pre-review to improve UX for myself, but welcome to any post-merge feedback!

@joverlee521 joverlee521 merged commit 841b188 into main Apr 11, 2024
2 checks passed
@joverlee521 joverlee521 deleted the default-branch-runs branch April 11, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathogen workflow status page includes non-default branch runs
1 participant