Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing https in the links #26

Merged
merged 2 commits into from
Feb 27, 2023
Merged

fix missing https in the links #26

merged 2 commits into from
Feb 27, 2023

Conversation

j23414
Copy link
Contributor

@j23414 j23414 commented Feb 26, 2023

Description of proposed changes

Fix some links in the README which was directing people to non-existent github files.

README.md Outdated
Comment on lines 53 to 55
[https://data.nextstrain.org/files/zika/sequences.fasta.xz](https://data.nextstrain.org/files/zika/sequences.fasta.xz)
and metadata from
[https://data.nextstrain.org/files/zika/metadata.tsv.gz](data.nextstrain.org/files/zika/metadata.tsv.gz).
[https://data.nextstrain.org/files/zika/metadata.tsv.gz](https://data.nextstrain.org/files/zika/metadata.tsv.gz).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @tsibley caught this earlier in #15 (comment) with a different suggestion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @victorlin and @tsibley! Yes, auto-linking base URLs is more streamlined.

Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase to squash the commits together? Otherwise looks good.

@j23414 j23414 merged commit 98d7d65 into main Feb 27, 2023
@j23414 j23414 deleted the fix/readme_links branch February 27, 2023 22:31
j23414 pushed a commit that referenced this pull request May 1, 2023
* rely on auto-linking of base URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants