Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent extend from modifying extended slots #106

Merged
merged 1 commit into from
Oct 7, 2023
Merged

fix: prevent extend from modifying extended slots #106

merged 1 commit into from
Oct 7, 2023

Conversation

mskelton
Copy link
Collaborator

@mskelton mskelton commented Sep 19, 2023 •
edited
Loading

Description

Fixes #104

The change to joinObjects was causing extended slots to be mutated incorrectly.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@mskelton
Copy link
Collaborator Author

mskelton commented Oct 6, 2023

@jrgarciadev Could I get a review on this?

@jrgarciadev jrgarciadev merged commit 651bbf7 into main Oct 7, 2023
4 checks passed
@mskelton mskelton deleted the fix-extend-merging branch October 28, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgarciadev jrgarciadev jrgarciadev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extend does not work as expected
2 participants
@mskelton @jrgarciadev