fix: VariantProps doesn't type responsiveVariants in global configura… #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskelton
reviewed
Feb 23, 2024
mskelton
force-pushed
the
fix-responsive-variants-on-create-tv
branch
from
b0dd8d4
to
8360015
Compare
mskelton
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #131
Resolved typescript issue with VariantProps not including responsiveVariants when utilizing createTV with defaultConfig by ensuring responsiveVariants is correctly typed in TVReturnType. I've also added a couple of tests which cover the case that currently fails.
A new CreateTV type has been introduced to ensure that this update does not interfere with users who employ tv as their primary function.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).