Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sbdi-gtdb R09-RS220 #765

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Add sbdi-gtdb R09-RS220 #765

merged 2 commits into from
Jul 23, 2024

Conversation

erikrikarddaniel
Copy link
Member

@erikrikarddaniel erikrikarddaniel commented Jul 23, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

The latest release of Sativa vetted GTDB added.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0b9a70b

+| ✅ 285 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-23 12:10:19

@d4straub
Copy link
Collaborator

Uff, failing tests are
Can't stage file [https://files.plutof.ut.ee](https://files.plutof.ut.ee/ ...
related to #764. We'll need to fix that asap :D

d4straub
d4straub approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erikrikarddaniel
Copy link
Member Author

Uff, failing tests are Can't stage file [https://files.plutof.ut.ee](https://files.plutof.ut.ee/ ... related to #764. We'll need to fix that asap :D

Easiest is perhaps to comment out that test for the moment? I can do that in this PR if you want to, then try to find urls for the files in another PR.

@d4straub
Copy link
Collaborator

Easiest would be if I bypass tests and just merge it. The fix for the links could come in a follow-up PR. Is that ok with you?

@erikrikarddaniel
Copy link
Member Author

Easiest would be if I bypass tests and just merge it. The fix for the links could come in a follow-up PR. Is that ok with you?

Go ahead!

@d4straub d4straub merged commit e66c9d3 into nf-core:dev Jul 23, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikrikarddaniel @d4straub