Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chromatogram extractor module #329

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Add chromatogram extractor module #329

merged 5 commits into from
Sep 19, 2024

Conversation

jonasscheid
Copy link
Collaborator

@jonasscheid jonasscheid commented Sep 12, 2024 •
edited
Loading

Closing #328

This module extracts MS1 TICs and plots them in multiQC

Screenshot 2024-09-12 at 22 54 59

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mhcquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit eb79fce

+| ✅ 236 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-19 12:35:13

marissaDubbelaar
marissaDubbelaar approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@marissaDubbelaar marissaDubbelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasscheid jonasscheid merged commit da9fc4d into nf-core:dev Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marissaDubbelaar marissaDubbelaar marissaDubbelaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasscheid @marissaDubbelaar