Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dereplicate #6234

Merged
merged 7 commits into from
Aug 25, 2024
Merged

Dereplicate #6234

merged 7 commits into from
Aug 25, 2024

Conversation

chriswyatt1
Copy link
Contributor

PR checklist

Closes #6232

  • [x ] This comment contains a description of changes (with reason).
  • [ NA] If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x ] If necessary, include test data in your PR.
  • [x ] Remove all TODO statements.
  • [x ] Emit the versions.yml file.
  • [x ] Follow the naming conventions.
  • [x ] Follow the parameters requirements.
  • [x ] Follow the input/output options guidelines.
  • [ x] Add a resource label
  • [x ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x ] nf-core modules test <MODULE> --profile docker
      • [x ] nf-core modules test <MODULE> --profile singularity
      • [NO ] nf-core modules test <MODULE> --profile conda

@chriswyatt1 chriswyatt1 requested a review from a team as a code owner August 21, 2024 15:29
@chriswyatt1 chriswyatt1 requested review from koenbossers and removed request for a team August 21, 2024 15:29
@chriswyatt1
Copy link
Contributor Author

Need to get raw data on test datasets, I cannot find any thing similar.
It needs to be a fasta file with headers that are repeated, so that it can combine them with a count

@SPPearce
Copy link
Contributor

Could we make a fasta file on the fly, inside the test itself then?

@SPPearce
Copy link
Contributor

For instance:

Channel.of(
   'ACGTCGT',
   'ACGTCGT',
   'ACGTCGT'
    )
   .collectFile(name: 'test.fasta', newLine: true)

@chriswyatt1
Copy link
Contributor Author

Thanks Simon. I did try the way you suggested in your last comment. But it could not find test.fasta in the test when I ran it. Didn't manage to work it out, but found some acceptable into data from nf-core datasets, so ran from that instead.

@chriswyatt1 chriswyatt1 added this pull request to the merge queue Aug 25, 2024
Merged via the queue into nf-core:master with commit 3da38da Aug 25, 2024
190 checks passed
@chriswyatt1 chriswyatt1 deleted the dereplicate branch August 25, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module:vsearch/deduplicate
2 participants