-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parabricks haplotypecaller version update and tests migrated to nf-test #6976
base: master
Are you sure you want to change the base?
Parabricks haplotypecaller version update and tests migrated to nf-test #6976
Conversation
modules/nf-core/parabricks/haplotypecaller/tests/nextflow.config
Outdated
Show resolved
Hide resolved
@Furentsu I added a few comments. Are you able to run the tests locally to create the snap? |
Co-authored-by: Famke Bäuerle <45968370+famosab@users.noreply.github.com>
@nf-core-bot fix linting |
I tested on our HPC with a GPU but I get the "Could not find accessible GPUs" error. |
For me the current test profile also did not work. SO I changed again the docker.runPtions and just ran it with --profile docker (in tests/config/nf-test.config)
|
…m/Furentsu/nf-core_modules into parabricks_haplotypecaller_update
hmm, out of memory error. is that fixable on your side or do we need bigger instances? |
@mashehu I have already added a flag for low memory usage, it should do.. on our HPC I get a different error that should be due to the test files used:
|
All tests are now passing on our HPC. I do not understand why they're not passing here |
Linting fails because one of the tests produces an empty file (probably because no variants were called). So you'll either need to change the test data or the assertion :) |
PR checklist
Parabricks haplotypecaller was updated to latest version (4.4.0-1) and tests were migrated to nf-test.
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda