Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parabricks haplotypecaller version update and tests migrated to nf-test #6976

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Furentsu
Copy link
Contributor

PR checklist

Parabricks haplotypecaller was updated to latest version (4.4.0-1) and tests were migrated to nf-test.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@Furentsu Furentsu requested a review from a team as a code owner November 12, 2024 13:10
@Furentsu Furentsu self-assigned this Nov 12, 2024
@Furentsu Furentsu added the help wanted Extra attention is needed label Nov 12, 2024
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
tests/config/nf-test.config Show resolved Hide resolved
@famosab
Copy link
Contributor

famosab commented Nov 14, 2024

@Furentsu I added a few comments. Are you able to run the tests locally to create the snap?

@mashehu
Copy link
Contributor

mashehu commented Nov 15, 2024

@nf-core-bot fix linting

@Furentsu
Copy link
Contributor Author

I tested on our HPC with a GPU but I get the "Could not find accessible GPUs" error.

@famosab
Copy link
Contributor

famosab commented Nov 15, 2024

I tested on our HPC with a GPU but I get the "Could not find accessible GPUs" error.

For me the current test profile also did not work. SO I changed again the docker.runPtions and just ran it with --profile docker (in tests/config/nf-test.config)

docker.runOptions = '-u $(id -u):$(id -g) --gpus device=0 --platform=linux/amd64'

@mashehu
Copy link
Contributor

mashehu commented Nov 15, 2024

hmm, out of memory error. is that fixable on your side or do we need bigger instances?

@Furentsu
Copy link
Contributor Author

@mashehu I have already added a flag for low memory usage, it should do.. on our HPC I get a different error that should be due to the test files used:

Chr chr21 not found in the reference. Exiting., exiting.

@Furentsu
Copy link
Contributor Author

All tests are now passing on our HPC. I do not understand why they're not passing here

@famosab
Copy link
Contributor

famosab commented Nov 15, 2024

Linting fails because one of the tests produces an empty file (probably because no variants were called). So you'll either need to change the test data or the assertion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants