Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda version tag to use pixelator 0.18.2 #107

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix conda version tag to use pixelator 0.18.2 #107

merged 4 commits into from
Jul 31, 2024

Conversation

fbdtemme
Copy link
Collaborator

@fbdtemme fbdtemme commented Jul 30, 2024 •
edited
Loading

  • Fix an issue where conda pixelator package version was not properly bumped with the 1.3.0 release.
  • Bump version to 1.3.1

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5e18511

+| ✅ 215 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.3.1
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-31 09:55:03

@fbdtemme fbdtemme changed the base branch from master to dev July 30, 2024 12:30
@fbdtemme fbdtemme requested a review from ambarrio July 30, 2024 12:36
ambarrio
ambarrio approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@ambarrio ambarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we create some version tag that you can easily substitute and then, avoid forgetting to update any of these?

@fbdtemme fbdtemme merged commit 51d0486 into dev Jul 31, 2024
4 checks passed
@fbdtemme fbdtemme mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambarrio ambarrio ambarrio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbdtemme @ambarrio