Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process_high->64GB ram/process_high_memory->128GB #91

Merged
merged 2 commits into from
May 28, 2024
Merged

process_high->64GB ram/process_high_memory->128GB #91

merged 2 commits into from
May 28, 2024

Conversation

johandahlberg
Copy link
Collaborator

@johandahlberg johandahlberg commented May 27, 2024 •
edited
Loading

Adjust the resource requirement so that process_high used 64GB of RAM and process_high_memory used 128GB of RAM.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pixelator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 71b413c

+| ✅ 197 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   5 tests had warnings |!
-| ❌   2 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.1.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-27 15:27:03

@johandahlberg johandahlberg force-pushed the feature/change-process-high-to-use-64gb-ram branch from 433a867 to c41065b Compare May 27, 2024 14:59
@johandahlberg johandahlberg requested a review from fbdtemme May 27, 2024 15:00
@johandahlberg johandahlberg marked this pull request as ready for review May 27, 2024 15:00
fbdtemme
fbdtemme reviewed May 27, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [[PR #90](https://github.com/nf-core/pixelator/pull/90)] - Update pixelator to 0.17.1
- [[PR #90](https://github.com/nf-core/pixelator/pull/90)] - Add `pixelator single-cell layout` command
- [[PR #90](https://github.com/nf-core/pixelator/pull/90)] - The `graph` and `annotate` steps are now using `process_high` as their resource tags
- [[PR #91](https://github.com/nf-core/pixelator/pull/91)] - Set `process_medium` to use 64GB of RAM and `process_high_memory` to use 128GB of RAM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be process_high right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 🤦

@johandahlberg johandahlberg force-pushed the feature/change-process-high-to-use-64gb-ram branch from da7c814 to 71b413c Compare May 27, 2024 15:26
@johandahlberg johandahlberg merged commit c085f75 into nf-core:dev May 28, 2024
3 of 4 checks passed
@fbdtemme fbdtemme deleted the feature/change-process-high-to-use-64gb-ram branch May 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbdtemme fbdtemme fbdtemme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johandahlberg @fbdtemme