-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.2.0 #580
Release 2.2.0 #580
Conversation
adds missinf citations for bwameme
Resolve issues that cropped up when aligner and mt_aligner were different
Add option to generate csi index for managed variants
Change platform description and update vcf2cytosure conditional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some small stuff!
@@ -28,7 +28,8 @@ workflow ANNOTATE_GENOME_SNVS { | |||
analysis_type // string: [mandatory] 'wgs' or 'wes' | |||
ch_cadd_header // channel: [mandatory] [ path(txt) ] | |||
ch_cadd_resources // channel: [mandatory] [ path(annotation) ] | |||
ch_vcfanno_resources // channel: [mandatory] [ path(resources) ] | |||
ch_vcfanno_extra // channel: [mandatory] [ [path(vcf),path(index)] ] | |||
ch_vcfanno_resources // channel: [mandatory] [ [path(vcf),path(index),...] ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does ...
mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That it contains more than one vcf and index 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about [ path(vcfs), path(indices) ]
? 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still one list of multiple vcfs [ meta, [ vcf1, vcf2, vcf ], [tbi1, tbi2, tbi3] ]
? and not [ meta, vcf1, tbi1 , vc2, tbi2 , etc... ]
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never paid attention to this haha. 😅 How about [path(vcf1),path(index1),...,path(vcfn),path(indexn)]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope.. Its just a list containing paths and indices.. They are not grouped in any way :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I misunderstood, I edited my comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay. then I guess just ...
is fine!
ch_vcfanno_extra // channel: [mandatory] [ [path(vcf),path(index).....] ] | ||
ch_vcfanno_lua // channel: [mandatory] [ path(lua) ] | ||
ch_vcfanno_resources // channel: [mandatory] [ [path(vcf),path(index),.....] ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Updatevep from v110-112
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).