Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prerelease 3.14.0 fixes #1154

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Prerelease 3.14.0 fixes #1154

merged 7 commits into from
Jan 5, 2024

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Jan 4, 2024 •
edited
Loading

In this PR:

  • Disable an additional versions section that had crept it with recent MultiQC
  • Reorder preprocessing to delay strand inference until after filtering
  • Fix conditional publishing to avoid empty directories
  • Bump versions

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords marked this pull request as draft January 4, 2024 16:42
@pinin4fjords pinin4fjords changed the title Prerelease 3.14.0 fixes [WIP] Prerelease 3.14.0 fixes Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f06f298

+| ✅ 145 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: 3.14.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowRnaseq.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/rnaseq/rnaseq/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-05 09:51:14

@pinin4fjords pinin4fjords mentioned this pull request Jan 4, 2024
Closed
@pinin4fjords pinin4fjords changed the title [WIP] Prerelease 3.14.0 fixes Prerelease 3.14.0 fixes Jan 4, 2024
@pinin4fjords pinin4fjords requested a review from drpatelh January 4, 2024 18:38
@pinin4fjords pinin4fjords marked this pull request as ready for review January 4, 2024 18:38
drpatelh
drpatelh reviewed Jan 5, 2024
View reviewed changes
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
workflows/rnaseq.nf Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@drpatelh drpatelh mentioned this pull request Jan 5, 2024
Closed
@pinin4fjords @drpatelh
Apply suggestions from code review
f06f298 
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
drpatelh
drpatelh approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@drpatelh drpatelh merged commit 7ab1724 into dev Jan 5, 2024
35 checks passed
@drpatelh drpatelh deleted the prerelease_3.14.0_fixes branch January 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @drpatelh