This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Updating with changes from combiz fork
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of native groovy variables for true/false/null is preferable, however the nf-core schema returns a parameter not provided error if a boolean `false` parameter is provided. Reverted to strings for true/false/null until a solution is clear.
The use of ../ in a output file path creates issues when using GCP/AWS. The output paths in conf/modules.config were revised to omit these. Further optimization will be required to export reports to a specific reports folder, as this was previously achieved using the ../ paths.
|
@ewels, Hi, thanks for getting in touch. I have just updated nf-core-scflow from our side and soon will push to dev. Once Combiz accepts the PR, I think it will be great to update the forks. Will get back soon. Thanks. |
|
Hi @nfancy, That's great news, thanks for letting us know! We've been struggling to get in touch with Combiz - if you fancy jumping onto the nf-core slack channel for this pipeline it would be great to discuss how to move forward 😃 https://nfcore.slack.com/channels/scflow Thanks! Phil |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @combiz, @nfancy,
I've just created this PR from your fork to the main nf-core repo to try to bring in your changes. They're pretty old now (2021) but activity on the nf-core side for this pipeline is picking up so it would be nice to incorporate them before they get to stale if possible.
Please let me know if either of you are reading this, as we would like to change the head fork and have been trying to get in touch. If we get no response, once resolving this PR will will detach our fork to facilitate future maintenance and development.
Thanks both!
Phil