Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add deprecation notice #43

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add deprecation notice #43

merged 1 commit into from
Jun 13, 2024

Conversation

nictru
Copy link

@nictru nictru commented Jun 13, 2024

As discussed in the #scflow slack channel, this PR adds a deprecation notice to the Repo Readme.

I did not find any good examples in other archived pipelines since the archiving adds similar notices. An example can be found here

Copy link

YAML linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install yaml-lint
  • Fix the markdown errors
    • Run the test locally: yamllint $(find . -type f -name "*.yml" -o -name "*.yaml")
    • Fix any reported errors in your YAML files

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --fix
    • Manually resolve anything left from markdownlint .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@maxulysse
Copy link
Member

@nf-core-bot fix linting pretty please 🙏

@nictru
Copy link
Author

nictru commented Jun 13, 2024

Do we still have to make sure the CI passes in this situation?

@maxulysse
Copy link
Member

Do we still have to make sure the CI passes in this situation?

not really, but I like nice things

@maxulysse maxulysse merged commit 6c762dd into dev Jun 13, 2024
0 of 10 checks passed
@nictru nictru deleted the deprecation branch June 13, 2024 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants