Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template: replace docker.runOptions by containerOptions #2673

Closed
wants to merge 3 commits into from

Conversation

mirpedrol
Copy link
Member

Since userEmulation was deprecated from Nextflow, we recently added docker.runOptions = '-u $(id -u):$(id -g)' to the pipeline template for profiles docker and arm.
The problem of this is that it can't be overridden in one single process.

Instead, we can use 'containerOptions' which will allow us to override the option with modules.config.
See an example in crisprseq, where we were finding some permission errors in the containers and this solved the issue.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31c61ca) 73.41% compared to head (0a895b5) 73.27%.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants