Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test conda environment.yml name attribute #3161

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Sep 6, 2024

name should no longer be there: see nf-core/modules#6600

It's absence is already linted in modules with the environment.yml schema, so no need to check for its absence here.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@matthdsm
Copy link
Contributor

matthdsm commented Sep 6, 2024

There seems to be a typo in the changelog

@ewels
Copy link
Member Author

ewels commented Sep 6, 2024

Changelog CI failure seems unrelated 🤠

@ewels ewels merged commit 16d66cb into nf-core:dev Sep 6, 2024
83 checks passed
@ewels ewels deleted the module-lint-no-name branch September 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants