Complete the test files preliminarily. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap exception
fix: exceptions exiting have been modified.
Update LICENSE text
1. add test files to almost every files. 2. improve the code according to advices from @Harry-Chen in nfcim#11.
Harry-Chen
requested changes
Sep 24, 2021
test/exceptions_test.dart
Outdated
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| group('description', () { |
There was a problem hiding this comment.
What's this blank file for?
There was a problem hiding this comment.
This means waiting to be added.
There was a problem hiding this comment.
Then this file shouldn't be included in this PR.
| }); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are there so many blank lines below?
There was a problem hiding this comment.
I've now removed Spaces for convenience when I was coding.
test/utilities_test.dart
Outdated
| assert(Uint8List.fromList([]).toHexString() == ""); | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Please add a new line here.
Harry-Chen
requested changes
Sep 26, 2021
test/exceptions_test.dart
Outdated
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| group('description', () { |
There was a problem hiding this comment.
Then this file shouldn't be included in this PR.
1. exclude exception_test.dart; 2. fix all comments.
Chever-John
force-pushed
the
dev-perfect_test_files
branch
from
8140565 to
2b3d5d0
Compare
change path to 'test' directory and run command with the 'flutter format .'.
Chever-John
force-pushed
the
dev-perfect_test_files
branch
from
446713e to
1474e99
Compare
Its content has been split into separate files.
Signed-off-by: Harry Chen <i@harrychen.xyz>
Signed-off-by: Harry Chen <i@harrychen.xyz>
Harry-Chen
requested changes
Sep 28, 2021
There was a problem hiding this comment.
I have fixed some problems in your code. Please pull my changes.
There is a failing test:
Running "flutter pub get" in ndef... 9.9s
00:23 +4 -1: ndef\test\records\handover_test.dart: encode and decode handover record [E]
'file:///ndef/test/common.dart': Failed assertion: line 21 pos 12: 'encodeNdefMessage(messages[i]).toHexString() == hexStrings[i]': is not true.
dart:core _AssertionError._throwNew
test\common.dart 21:12 testGenerate
test\records\handover_test.dart 88:7 main.<fn>.<fn>
00:24 +22 -1: Some tests failed.
Please fix it and I will merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have
And the tasks as followed: