-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PRIDE validation package #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress so far. I think my review comments on nfdi4plants/arc-validate#88 should be addressed before publishing (meanining: setting Publish true
in the header).
Small request: could you add more metadata to the header? I know these are optional but especially tags would be nice. After that we can merge this so that it is accessible for the github api-based package installation already, and move to production once the helpers are refactored.
@omaus sorry to nudge you so much but can you please add author and tag metadata so we can merge this? Should not take long. |
Yeah thx, pls check if it is done right (I'm esp. unsure about the |
Lgtm, but pls do not set |
But commiting to this repo makes the package available as prerease already |
Done. |
f3867e4
to
2278fd7
Compare
thanks @omaus, heads up that i will push some changes to your branch to test some ci capabilities |
fix tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allright, testing pipeline seems to work and also caught multiple problems (see pipeline output).
Please make sure that the version in the yaml metadata is the same as indicated in the file name, and make sure that the script can run. Compilation of the script in ci fails, and i suspect that that is due to the versions of the nuget packages not being pinned, and ARCExpect API having changed since you submitted the PR.
I will add a test that checks that all nuget references are pinned.
Unit test says that version is wrong. I don't see why that should be the case. The file's name is "pride@1.0.0.fsx", YAML tags: MajorVersion: 1
MinorVersion: 0
PatchVersion: 0 ??? |
Those are the default values the metadata class gets initialized with if the frontmatter is invalid !!! |
Also, |
This PR