Links in angle brackets #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make "<http://example.com>" parse the same as "(http://example.com)" by adding angle bracket versions of the existing logic for braces, brackets and parentheses. This breaks the indenting in parser.js: I'll fix this in a separate commit to make the diffs legible.
Move the RHS of the assignments over to match the angle bracket lines.
dbkr
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 4, 2016
To pull in nfrasser/linkifyjs#166
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 4, 2016
To pull in nfrasser/linkifyjs#166
This was referenced Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds behaviour for angle brackets to match the current behaviour for brackets, braces and parentheses, meaning that
<http://example.com>will now not include the final '>' (buthttp://example.com/foo_<bar>will).Tests included for both of these cases.
I've also broken it up into two commits, one with the functional change and one whitespace commit changing the whitespace on other lines to match, so suggest reading the two commits separately.