Allow null overrides in options for target and className #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrasser
reviewed
Feb 1, 2017
src/linkify/utils/options.js
Outdated
| @@ -23,13 +23,13 @@ function Options(opts) { | |||
| this.formatHref = opts.formatHref || defaults.formatHref; | |||
| this.nl2br = opts.nl2br || defaults.nl2br; | |||
| this.tagName = opts.tagName || defaults.tagName; | |||
| this.target = opts.target || defaults.target; | |||
| this.target = opts.target !== undefined ? opts.target : defaults.target; | |||
There was a problem hiding this comment.
What do you think about using hasOwnProperty instead of the !== undefined check?
e.g.,
this.target = opts.hasOwnProperty('target') ? opts.target : defaults.target;
|
Sounds fine to me. I'll update the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type coercion means we cannot override options with null values (or any other falsy values for that matter). This adds undefined checks for target and className (which suited my requirements) and tests to cover these cases.
What do you think? Correct approach? Would other option values benefit from null values?