Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identified issues with dev environment #1464

Closed
JeffLowe opened this issue Feb 23, 2022 · 3 comments
Closed

Fix identified issues with dev environment #1464

JeffLowe opened this issue Feb 23, 2022 · 3 comments
Assignees
Labels

Comments

@JeffLowe
Copy link
Contributor

Resolve the following issues with dev environment identified in working session between @dashcraft and @alanshaw

  1. salt was a random value

  2. API token in readme for api is for a different magic link id than the one in seeded data

  3. Database token in readme is incorrect, should be:

  4. Pinning services api, requires a PSA allow list for authoritzation

@JeffLowe
Copy link
Contributor Author

Resolved with #1462

@plwileverts
Copy link

plwileverts commented Apr 12, 2022

@JeffLowe @dashcraft does this actually close this issue? Noticing that 1462 notes "Linked to #1464 as part of solution (will not close the whole thing, but a nice quick win improvement)"

@JeffLowe
Copy link
Contributor Author

Yeah, that could be confusing. Let me clarify.

The immediate partial solution in #1462 addressing current setup became the full fix once #1690 was introduced ( which focuses on docker setup ).
So, no more work is needed on this ticket. What remains needed is being worked on in #1690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants