Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA pins changed from being pinned to cluster by source CID to content CID #1490

Closed
hugomrdias opened this issue Feb 28, 2022 · 1 comment
Closed

PSA pins changed from being pinned to cluster by source CID to content CID #1490

hugomrdias opened this issue Feb 28, 2022 · 1 comment
Assignees
@alanshaw
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@hugomrdias
Copy link
Contributor

Currently we use content_cid to pin to cluster since this commit but we should use source_cid because car uploads are pinned directly by root cid which is the source_cid in the db.

The issue is, when we run the cron to check pin status we dont know if we should use content_cid or source_cid to call cluster.

Possible solution is to re-pin everything that as a source_cid different from content_cid
@hugomrdias hugomrdias added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up and removed need/triage Needs initial labeling and prioritization labels Feb 28, 2022
@alanshaw alanshaw mentioned this issue Mar 14, 2022
Merged
alanshaw pushed a commit that referenced this issue Mar 16, 2022
fix: pin by source CID (#1634)
4ab48ce 
We need to pin by source CID to be consistent with all other uploads.

...also a fix to ensure the pin metadata is filtered correctly.

refs #1490

Part 2 is to pin all v0 source CIDs.
@dchoi27 dchoi27 added the need/update manually applied to any needing verbal update during meetings label Mar 17, 2022
@alanshaw
Copy link
Contributor

alanshaw commented Mar 21, 2022 •
edited
Loading

Fix has been merged and deployed to production.

TODO:

  • repin CIDs that were pinned by normalized CID to be pinned by cource CID. ⏳

Note there are 9m of these so it's going to take a while.

@alanshaw alanshaw removed the need/update manually applied to any needing verbal update during meetings label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanshaw alanshaw

Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alanshaw @hugomrdias @dchoi27 @elizabeth-griffiths